Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jinja filter and function for median and statistical_mode #105554

Merged
merged 5 commits into from Dec 27, 2023

Conversation

TheFes
Copy link
Contributor

@TheFes TheFes commented Dec 12, 2023

Proposed change

Add jinja filters and functions for mode and median

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@TheFes TheFes changed the title Jinja filter and function for median and mode Jinja filter and function for median and mode Dec 12, 2023
@TheFes TheFes marked this pull request as ready for review December 12, 2023 12:20
@TheFes TheFes requested a review from a team as a code owner December 12, 2023 12:20
Copy link
Contributor

@tetele tetele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, all in all

homeassistant/helpers/template.py Outdated Show resolved Hide resolved
homeassistant/helpers/template.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft December 12, 2023 14:02
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@TheFes TheFes marked this pull request as ready for review December 12, 2023 14:06
@home-assistant home-assistant bot requested a review from tetele December 12, 2023 14:07
homeassistant/helpers/template.py Outdated Show resolved Hide resolved
homeassistant/helpers/template.py Outdated Show resolved Hide resolved
TheFes and others added 2 commits December 12, 2023 15:11
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@frenck
Copy link
Member

frenck commented Dec 27, 2023

I understand the context, but I think mode as a jinja2 function is confusing/ambiguous for a name (but I lack a better alternative/suggestion).

@tetele
Copy link
Contributor

tetele commented Dec 27, 2023

statistic_mode, perhaps?

@frenck frenck changed the title Jinja filter and function for median and mode Jinja filter and function for median and statistical_mode Dec 27, 2023
@frenck
Copy link
Member

frenck commented Dec 27, 2023

As discussed on Discord with @TheFes, renaming it to statistical_mode

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @TheFes 👍

../Frenck

@frenck frenck merged commit a823edf into home-assistant:dev Dec 27, 2023
53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2023
@TheFes TheFes deleted the median_mode_2 branch January 5, 2024 07:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants