Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move core fundamental components into bootstrap #105560

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Move core fundamental components into bootstrap #105560

merged 4 commits into from
Jan 22, 2024

Conversation

frenck
Copy link
Member

@frenck frenck commented Dec 12, 2023

Proposed change

Proposal to move some core components from default_config into the bootstrap.

The goal is to make the default_config smaller and make built-in/fundamental/default functionality part of just Home Assistant itself.

Changes:

  • Load backup component in case there is no Supervisor. This was in default_config, while the Supervisor backup was in the bootstrap.
  • Move components providing core functionality into bootstrap
  • Move key features like automation, script, etc into the bootstrap
  • Move built-in helpers into the bootstrap

Moving these will have no direct impact.

Other are left in default_config because they do have impact. For example, map, my, cloud, e.d., all have impact on e.g., the sidebar or other places a user may not want to use for, whatever, reason.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (default_config) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of default_config can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign default_config Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@emontnemery emontnemery marked this pull request as ready for review January 22, 2024 13:21
@emontnemery emontnemery requested a review from a team as a code owner January 22, 2024 13:21
tests/test_bootstrap.py Outdated Show resolved Hide resolved
@frenck
Copy link
Member Author

frenck commented Jan 22, 2024

Thanks, @emontnemery & @MartinHjelmare ❤️

../Frenck

@frenck frenck merged commit 8020783 into dev Jan 22, 2024
53 checks passed
@frenck frenck deleted the frenck-2023-1503 branch January 22, 2024 19:09
catsmanac pushed a commit to catsmanac/ha-core-dev that referenced this pull request Jan 23, 2024
Co-authored-by: Erik <erik@montnemery.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants