-
-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move core fundamental components into bootstrap #105560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
32ff067
to
c127299
Compare
emontnemery
reviewed
Jan 22, 2024
MartinHjelmare
approved these changes
Jan 22, 2024
8 tasks
Thanks, @emontnemery & @MartinHjelmare ❤️ ../Frenck |
catsmanac
pushed a commit
to catsmanac/ha-core-dev
that referenced
this pull request
Jan 23, 2024
Co-authored-by: Erik <erik@montnemery.com> Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Proposal to move some core components from
default_config
into the bootstrap.The goal is to make the
default_config
smaller and make built-in/fundamental/default functionality part of just Home Assistant itself.Changes:
backup
component in case there is no Supervisor. This was indefault_config
, while the Supervisor backup was in the bootstrap.Moving these will have no direct impact.
Other are left in
default_config
because they do have impact. For example,map
,my
,cloud
, e.d., all have impact on e.g., the sidebar or other places a user may not want to use for, whatever, reason.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: