Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name slot to HassClimateGetTemperature intent #105585

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Add name slot to HassClimateGetTemperature intent #105585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 15 additions & 1 deletion homeassistant/components/climate/intent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class GetTemperatureIntent(intent.IntentHandler):
"""Handle GetTemperature intents."""

intent_type = INTENT_GET_TEMPERATURE
slot_schema = {vol.Optional("area"): str}
slot_schema = {vol.Optional("area"): str, vol.Optional("name"): str}

async def async_handle(self, intent_obj: intent.Intent) -> intent.IntentResponse:
"""Handle the intent."""
Expand Down Expand Up @@ -49,6 +49,20 @@ async def async_handle(self, intent_obj: intent.Intent) -> intent.IntentResponse
if climate_state is None:
raise intent.IntentHandleError(f"No climate entity in area {area_name}")

climate_entity = component.get_entity(climate_state.entity_id)
elif "name" in slots:
# Filter by name
entity_name = slots["name"]["value"]

for maybe_climate in intent.async_match_states(
hass, name=entity_name, domains=[DOMAIN]
):
climate_state = maybe_climate
break

if climate_state is None:
raise intent.IntentHandleError(f"No climate entity named {entity_name}")

climate_entity = component.get_entity(climate_state.entity_id)
else:
# First entity
Expand Down
15 changes: 14 additions & 1 deletion tests/components/climate/test_intent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ async def test_get_temperature(
state = response.matched_states[0]
assert state.attributes["current_temperature"] == 10.0

# Select by area instead (climate_2)
# Select by area (climate_2)
response = await intent.async_handle(
hass,
"test",
Expand All @@ -166,6 +166,19 @@ async def test_get_temperature(
state = response.matched_states[0]
assert state.attributes["current_temperature"] == 22.0

# Select by name (climate_2)
response = await intent.async_handle(
hass,
"test",
climate_intent.INTENT_GET_TEMPERATURE,
{"name": {"value": "Climate 2"}},
)
assert response.response_type == intent.IntentResponseType.QUERY_ANSWER
assert len(response.matched_states) == 1
assert response.matched_states[0].entity_id == climate_2.entity_id
state = response.matched_states[0]
assert state.attributes["current_temperature"] == 22.0


async def test_get_temperature_no_entities(
hass: HomeAssistant,
Expand Down