Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inheriting FrozenOrThawed with custom init #105624

Merged
merged 1 commit into from Dec 13, 2023
Merged

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Dec 13, 2023

Proposed change

Allow inheriting FrozenOrThawed with custom __init__

The pattern is used by philips_js in a misguided workaround to allow adding fields without default values in a subclass:

@dataclass
class PhilipsTVBinarySensorEntityDescription(BinarySensorEntityDescription):
"""A entity description for Philips TV binary sensor."""
def __init__(self, recording_value, *args, **kwargs) -> None:
"""Set up a binary sensor entity description and add additional attributes."""
super().__init__(*args, **kwargs)
self.recording_value: str = recording_value

While philips_js should just set the kw_only flag to True, we should still allow this to lessen the risk of breaking similar patterns in custom integrations.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck merged commit 22c3847 into dev Dec 13, 2023
53 checks passed
@frenck frenck deleted the fix_frozen_or_thawed_2 branch December 13, 2023 09:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants