Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set volume_step in cmus media_player #105667

Merged
merged 1 commit into from Dec 14, 2023
Merged

Set volume_step in cmus media_player #105667

merged 1 commit into from Dec 14, 2023

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Dec 13, 2023

Proposed change

Set volume_step in cmus media_player

Repeated calls to volume up/down service will work: cmus media player is polled, which means update is called after each service call

Background in PR #105574

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Comment on lines -160 to -162
if left != right:
current_volume = float(left + right) / 2
else:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how crucial this calculation of an average volume is for the volume up / down.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The averaging is already done in the state update for _attr_volume_level so the base implementation of volume up/down will have the same behavior.

@MartinHjelmare MartinHjelmare merged commit c10b460 into dev Dec 14, 2023
18 checks passed
@MartinHjelmare MartinHjelmare deleted the cmus_volume_step branch December 14, 2023 23:52
Bre77 pushed a commit to Bre77/core that referenced this pull request Dec 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants