Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small speed up to data entry flow steps #105713

Merged
merged 1 commit into from Dec 14, 2023
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 14, 2023

Proposed change

Instead of checking if the flow is completed with
a linear tuple search each time, use a constant
set

Noticed while profiling startup

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Instead of checking if the flow is completed with
a linear tuple search each time, use a constant
set
@bdraco bdraco marked this pull request as ready for review December 14, 2023 07:37
@bdraco bdraco requested a review from a team as a code owner December 14, 2023 07:37
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I understand correctly, this change will prevent creating this list for every flow it has to check?

@bdraco
Copy link
Member Author

bdraco commented Dec 14, 2023

Yes and it won't have to do a linear search since it's a set now

@joostlek joostlek merged commit 0d9a583 into dev Dec 14, 2023
49 checks passed
@joostlek joostlek deleted the small_speed_up_data_entry_flows branch December 14, 2023 16:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants