Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce overhead to connect dispatcher #105715

Merged
merged 1 commit into from Dec 16, 2023
Merged

Reduce overhead to connect dispatcher #105715

merged 1 commit into from Dec 16, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 14, 2023 •
edited

Proposed change

  • We tend to have 1000s (or 10000s) of connected dispatchers which makes these prime targets to reduce overhead/memory

  • Instead of creating new functions to wrap log exceptions each time use partials which reuses the function body and only creates new arguments

Previous similar optimizations #103307 #93602

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Reduce overhead connect dispatcher
8765a30 
- We tend to have 1000s (or 10000s) of connected dispatchers which
  makes these prime targets to reduce overhead/memory

- Instead of creating new functions to wrap log exceptions each time
  use partials which reuses the function body and only create new
  arguments

Previous optimizations #103307 #93602
@bdraco bdraco changed the title Reduce overhead connect dispatcher Reduce overhead to connect dispatcher Dec 14, 2023
@bdraco
Copy link
Member Author

bdraco commented Dec 14, 2023 •
edited

Testing seems fine. Saved a bit of ram on my production. (~7MiB) ... I do have a lot of dispatchers though so thats likely a outlier improvement

Need to do more testing but too tired so something for tomorrow

@bdraco bdraco marked this pull request as ready for review December 15, 2023 06:10
@bdraco bdraco requested a review from a team as a code owner December 15, 2023 06:10
@bdraco
Copy link
Member Author

bdraco commented Dec 15, 2023

Manual testing is 👍

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Dec 15, 2023
@MartinHjelmare MartinHjelmare merged commit 47f8e08 into dev Dec 16, 2023
53 checks passed
@MartinHjelmare MartinHjelmare deleted the dispatcher_wrapper branch December 16, 2023 09:16
@bdraco
Copy link
Member Author

bdraco commented Dec 16, 2023

thanks

@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed core smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bdraco @MartinHjelmare @frenck