Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Starline Service Mode switch #105741

Merged
merged 3 commits into from Dec 20, 2023
Merged

Add Starline Service Mode switch #105741

merged 3 commits into from Dec 20, 2023

Conversation

Anonym-tsk
Copy link
Contributor

@Anonym-tsk Anonym-tsk commented Dec 14, 2023 •
edited

Proposed change

Added Starline Service Mode switch

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Anonym-tsk Anonym-tsk mentioned this pull request Dec 14, 2023
Merged
8 tasks
@home-assistant home-assistant bot marked this pull request as draft December 14, 2023 15:57
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Anonym-tsk @joostlek
Update homeassistant/components/starline/strings.json
c68e196 
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@Anonym-tsk Anonym-tsk marked this pull request as ready for review December 14, 2023 15:59
@joostlek joostlek changed the title Starline Service Mode switch Add Starline Service Mode switch Dec 14, 2023
@Anonym-tsk
Copy link
Contributor Author

@joostlek please merge this PR

@joostlek joostlek merged commit 33bcf70 into home-assistant:dev Dec 20, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed integration: starline Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Anonym-tsk @joostlek