Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mode validation in Climate entity component #105745

Merged
merged 14 commits into from Dec 27, 2023

Conversation

gjohansson-ST
Copy link
Member

Proposed change

Implement mode validation in climate entity component. Same as previously been done with fan in #104560

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (climate) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of climate can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign climate Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add translation support (See fan presets for an example)

@gjohansson-ST
Copy link
Member Author

You could add translation support (See fan presets for an example)

I have?

"message": "{mode_type} mode {mode} is not valid. {mode_type} valid modes are: {modes}."

@gjohansson-ST
Copy link
Member Author

gjohansson-ST commented Dec 14, 2023

Anyway I see now this won't be good for translations so I'll redo that part so it's better for translation
Fixed

@gjohansson-ST gjohansson-ST marked this pull request as draft December 14, 2023 21:33
@gjohansson-ST gjohansson-ST force-pushed the validate-modes-in-climate branch 2 times, most recently from 95308dc to 957d3e4 Compare December 21, 2023 20:57
@bdraco
Copy link
Member

bdraco commented Dec 26, 2023

Looks like there is too much going on and github is rate limiting CI

@gjohansson-ST gjohansson-ST reopened this Dec 27, 2023
@gjohansson-ST gjohansson-ST merged commit 83f4d3a into dev Dec 27, 2023
98 of 99 checks passed
@gjohansson-ST gjohansson-ST deleted the validate-modes-in-climate branch December 27, 2023 13:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2023
@joostlek
Copy link
Member

Apparently, custom integrations have list of ints as modes 🤦🏻 #107633

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants