New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable user profiles on login screen #105749
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Thanks for listening to—what I assume was the reason here—security concerns! 🙏 |
Is this going to affect the mfa module and authentication related to it? |
Thanks for taking our concerns seriously. Only point for future issues, don't treat us like we are stupid in the beginning. We all understand everyone makes misstakes and it will take some time to fix things. Just say: we are reviewing/implementing/fixing. But anyway like they say in dutch; ""beter ten halve gekeerd dan ten hele gedwaald": "better to turn back half way than to go astray altogether" Thanks |
For reference: The blog post mentioned above: https://www.home-assistant.io/blog/2023/12/14/disabling-new-login-page-functionality/ |
Proposed change
This PR disables the ability to log in using the user profile on the login page.
More details with reasoning behind this will be published separately from this PR in a blog post.
Before & after screenshot:
ℹ️ This PR focusses on the minimal change set to make this happen while making the linters and tests happy.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: