Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable user profiles on login screen #105749

Merged
merged 1 commit into from Dec 14, 2023
Merged

Disable user profiles on login screen #105749

merged 1 commit into from Dec 14, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Dec 14, 2023

Proposed change

This PR disables the ability to log in using the user profile on the login page.

More details with reasoning behind this will be published separately from this PR in a blog post.

Before & after screenshot:

CleanShot 2023-12-14 at 18 55 32@2x

ℹ️ This PR focusses on the minimal change set to make this happen while making the linters and tests happy.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (auth) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of auth can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign auth Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@frenck frenck merged commit cc75430 into dev Dec 14, 2023
53 checks passed
@frenck frenck deleted the frenck-2023-1506 branch December 14, 2023 19:28
frenck added a commit that referenced this pull request Dec 14, 2023
@PattaFeuFeu
Copy link

Thanks for listening to—what I assume was the reason here—security concerns! 🙏

@jprokopowich
Copy link

Is this going to affect the mfa module and authentication related to it?

@edwinligthart
Copy link

Thanks for taking our concerns seriously.

Only point for future issues, don't treat us like we are stupid in the beginning. We all understand everyone makes misstakes and it will take some time to fix things. Just say: we are reviewing/implementing/fixing.

But anyway like they say in dutch; ""beter ten halve gekeerd dan ten hele gedwaald": "better to turn back half way than to go astray altogether"

Thanks

@PattaFeuFeu
Copy link

More details with reasoning behind this will be published separately from this PR in a blog post.

For reference: The blog post mentioned above: https://www.home-assistant.io/blog/2023/12/14/disabling-new-login-page-functionality/

Bre77 pushed a commit to Bre77/core that referenced this pull request Dec 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants