New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay all ZHA polling until initialization of entities has completed #105814
Merged
dmulcahey
merged 18 commits into
home-assistant:dev
from
dmulcahey:dm/zha-delay-updates
Dec 27, 2023
Merged
Delay all ZHA polling until initialization of entities has completed #105814
dmulcahey
merged 18 commits into
home-assistant:dev
from
dmulcahey:dm/zha-delay-updates
Dec 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
elupus
reviewed
Dec 16, 2023
Adminiuga
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dmulcahey
force-pushed
the
dm/zha-delay-updates
branch
from
December 21, 2023 21:54
e0bc286
to
67dbffc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR delays all forms of polling that ZHA does (device available checking, entities that are polled for state, etc.) until after ZHA has started and completed initialization. This will prevent us from queuing up unnecessary Zigbee network requests after HA is restarted. It also changes ZHA sensors to use a custom polling mechanism instead of relying on the OOTB HA polling. This is done so that we can randomize the polling interval within a range of time to ensure that all sensors aren't attempting to send Zigbee network requests at the same time.
TODO:
Can we catch when entities that are polling report on their own and disable polling for them?
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: