Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Airzone temperature range on new climate card #105830

Merged
merged 4 commits into from Dec 16, 2023

Conversation

Noltari
Copy link
Contributor

@Noltari Noltari commented Dec 15, 2023

Proposed change

It seems that with the new 2023.12 climate card, if both single target temperature and temperature ranges are exposed, the climate card won't detect the double setpoint as it did on < 2023.12, so let's expose only the temperature ranges and avoid exposing the single target temperature.
Also improve the tests because temperatures for the double setpoint were swapped.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari marked this pull request as ready for review December 16, 2023 10:03
@Noltari Noltari marked this pull request as draft December 16, 2023 10:04
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari marked this pull request as ready for review December 16, 2023 10:12
@Noltari Noltari changed the title airzone: climate: fix double setpoint Fix Airzone temperature range on new climate card Dec 16, 2023
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Noltari 👍

@gjohansson-ST gjohansson-ST added this to the 2023.12.4 milestone Dec 16, 2023
@gjohansson-ST gjohansson-ST merged commit 3be12c0 into home-assistant:dev Dec 16, 2023
23 checks passed
@Noltari Noltari deleted the airzone-fix-double-setpoint branch December 16, 2023 18:14
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airzone Aidoo double set point UI missing in HA 2023.12.0
3 participants