New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue warning if glances server version is 2 #105887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, apart from a small typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good imo, but I'm missing some rationale behind this change and a deadline. Why do we want to deprecate V2? Is it EoL (or planned to be soon)? Are there people that can't migrate to V3?
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There are multiple changes in the data provided by glances api between v2 server and v3 server. From the library side it is hard to maintain compatibility for both versions more details here. |
EDIT: I was wrong, the 0.5.0 version of the API wrapper library does not remove Glances v2 support yet. Glances does not seem to have any form of extended support: bug fixes are pushed to the latest release only, it seems. https://glances.readthedocs.io/en/latest/support.html @joostlek I understand that we want the HA platform to be stable and want to handle deprecations with advance notice. Not breaking users' setups is very important. Glances v3.0 was released in Sept 2018 The breaking changes in Glances v3 should not prohibit anyone from upgrading The number of Home Assistant users that is still on Glances v2 is probably very small, if not zero. The Glances v2 deprecation is introduced in v0.5.0 of the glances API wrapper package, which is currently merged in dev. Delaying this change would also delay the features that are currently in progress that have been requested by a few HA users. I am not able to judge if these reasons are good enough to break the rule of pre-announcing deprecations, but given that we should have deprecated v2 long ago, this might be worth an exception, maybe. I don't have a strong opinion on this, and am not a maintainer but I hope this gives you some additional context. |
Ah understood. Let me try to ask some others what they think about it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please copy some of the explanations about the deprecation to the breaking change paragraph in the PR description. |
We should update the docs about supported version too. |
@MartinHjelmare should we include this PR in this month's release? |
I think it's ok to wait until the February release. Users may see the warning in the log and that's ok, I think. |
Breaking change
Servers running Glances version 2 will be unsupported in 2024.8. We highly recommend that you upgrade to Glances version 3.
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: