Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TechnoVE integration #106029

Merged
merged 34 commits into from Jan 17, 2024

Conversation

Moustachauve
Copy link
Contributor

@Moustachauve Moustachauve commented Dec 19, 2023

Proposed change

This adds a new integration for TechnoVE Stations. These are Electric vehicle supply equipments (EVSE).
This first PR is implementing only the sensor entity. I'll port more features, like binary sensors and services, in subsequent PRs to make the reviews manageable.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Only the basic sensors for now.
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Moustachauve

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@Moustachauve Moustachauve marked this pull request as ready for review December 20, 2023 07:16
homeassistant/components/technove/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/technove/diagnostics.py Outdated Show resolved Hide resolved
homeassistant/components/technove/sensor.py Show resolved Hide resolved
homeassistant/components/technove/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/technove/strings.json Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft December 30, 2023 09:07
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@autinerd
Copy link
Contributor

autinerd commented Jan 2, 2024

Maybe splitting zeroconf into its own PR would be a good thing to keep this PR as small as possible

@joostlek
Copy link
Member

joostlek commented Jan 2, 2024

I think I've seen zeroconf be added in the same PR. Also because zeroconf also decides what kind of unique id you pick etc. But I have no experience with zeroconf.

@Moustachauve
Copy link
Contributor Author

Maybe splitting zeroconf into its own PR would be a good thing to keep this PR as small as possible

Done, I removed zeroconf from this PR so it can be included in a subsequent one.

@autinerd
Copy link
Contributor

autinerd commented Jan 5, 2024

One question I have, is it only allowed to use IP addresses in the integration? If not, I would prefer to use CONF_HOST over CONF_IP_ADDRESS.

@Moustachauve
Copy link
Contributor Author

One question I have, is it only allowed to use IP addresses in the integration? If not, I would prefer to use CONF_HOST over CONF_IP_ADDRESS.

The devices only have an IP address, but I guess technically one could assign a local DNS address to the device.

Copy link
Contributor

@autinerd autinerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my view, it now looks good :)

homeassistant/components/technove/config_flow.py Outdated Show resolved Hide resolved
tests/components/technove/test_coordinator.py Outdated Show resolved Hide resolved
tests/components/technove/test_coordinator.py Outdated Show resolved Hide resolved
tests/components/technove/test_coordinator.py Outdated Show resolved Hide resolved
tests/components/technove/test_sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft January 15, 2024 19:45
Moustachauve and others added 2 commits January 15, 2024 15:35
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@Moustachauve Moustachauve marked this pull request as ready for review January 15, 2024 21:48
@joostlek joostlek merged commit 44f2b8e into home-assistant:dev Jan 17, 2024
53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants