New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TechnoVE integration #106029
Implement TechnoVE integration #106029
Conversation
Only the basic sensors for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Maybe splitting zeroconf into its own PR would be a good thing to keep this PR as small as possible |
I think I've seen zeroconf be added in the same PR. Also because zeroconf also decides what kind of unique id you pick etc. But I have no experience with zeroconf. |
Done, I removed zeroconf from this PR so it can be included in a subsequent one. |
One question I have, is it only allowed to use IP addresses in the integration? If not, I would prefer to use |
The devices only have an IP address, but I guess technically one could assign a local DNS address to the device. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my view, it now looks good :)
Co-authored-by: Sid <27780930+autinerd@users.noreply.github.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Proposed change
This adds a new integration for TechnoVE Stations. These are Electric vehicle supply equipments (EVSE).
This first PR is implementing only the sensor entity. I'll port more features, like binary sensors and services, in subsequent PRs to make the reviews manageable.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: