New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate deprecated alarm control panel constants #106058
Merged
edenhaus
merged 7 commits into
dev
from
edenhaus-deprecate-alarm-control-panel-constants
Dec 20, 2023
Merged
Deprecate deprecated alarm control panel constants #106058
edenhaus
merged 7 commits into
dev
from
edenhaus-deprecate-alarm-control-panel-constants
Dec 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
core
deprecation
Indicates a breaking change to happen in the future
has-tests
integration: alarm_control_panel
Quality Scale: internal
labels
Dec 19, 2023
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
edenhaus
force-pushed
the
edenhaus-deprecate-alarm-control-panel-constants
branch
2 times, most recently
from
December 19, 2023 16:36
dcd3087
to
0e76bfc
Compare
edenhaus
force-pushed
the
edenhaus-deprecate-alarm-control-panel-constants
branch
from
December 19, 2023 20:42
0e76bfc
to
19e19ef
Compare
Test failures unrelated |
joostlek
approved these changes
Dec 20, 2023
edenhaus
deleted the
edenhaus-deprecate-alarm-control-panel-constants
branch
December 20, 2023 17:41
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
core
deprecation
Indicates a breaking change to happen in the future
has-tests
integration: alarm_control_panel
Quality Scale: internal
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
SSIA similar to #105736
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: