New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix freebox pairing in bridge mode #106131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hi, in case you missed it I pushed the fix of the unit test (forgot to add latest changes in my original commit). Should be fine now. |
Added a test covering the connection error case to have full code coverage. |
Hi, am I still missing anything to progress on this PR? Thanks |
Hello, could you please trigger the ci/cd? |
Seems it failed due to some api quota exceeded. |
Ignore host list API call error as it's not supported in bridge mode.
Hi, could you please trigger the CI run following the changes you requested? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @agrenott 👍
Ignore host list API call error as it's not supported in bridge mode.
Proposed change
Follow-up of PR #103221, applying the same solution to the pairing step:
host list API call is not supported when the Freebox is configured in bridge mode, so ignore
the error if it's a "nodev" one.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: