Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiopulse to 0.4.4 #106239

Merged
merged 4 commits into from Dec 22, 2023
Merged

Bump aiopulse to 0.4.4 #106239

merged 4 commits into from Dec 22, 2023

Conversation

atmurray
Copy link
Contributor

@atmurray atmurray commented Dec 22, 2023

Breaking change

Proposed change

Bump aiopulse version to 0.4.4 to fix issue for blinds that use status structure to indicate blinds that are fully open or closed.
Resolves:

  • issue with some blinds that don't report percentage correctly when fully open or closed; and
  • failure to reconnect to hub after connection is lost.

Diff of aiopulse module versions:
atmurray/aiopulse@v0.4.3...v0.4.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Bump aiopulse version to 0.4.4 to fix issue for blinds that use status structure to indicate blinds that are fully open or closed.
@joostlek
Copy link
Member

Can you still add a link to the diff of the library?

@atmurray
Copy link
Contributor Author

Can you still add a link to the diff of the library?

Is this sufficient?
atmurray/aiopulse@v0.4.3...v0.4.4

@joostlek
Copy link
Member

If you can put that in the PR description it would be brilliant :)

@joostlek joostlek changed the title Bump acmeda module dep aiopulse to 0.4.4 Bump aiopulse to 0.4.4 Dec 22, 2023
@joostlek joostlek added this to the 2023.12.4 milestone Dec 22, 2023
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure unrelated

@joostlek joostlek merged commit b7661b4 into home-assistant:dev Dec 22, 2023
48 of 49 checks passed
Bre77 pushed a commit to Bre77/core that referenced this pull request Dec 23, 2023
* Bump Rolease Acmeda version 

Bump aiopulse version to 0.4.4 to fix issue for blinds that use status structure to indicate blinds that are fully open or closed.

* Update manifest.json

* update requirements
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollease Acmeda Automate Integration stops working - "aiopulse.errors.NotConnectedException"
3 participants