New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reauth in Overkiz for config entries created prior to 2022.12 #106251
Conversation
Hey there @vlebourl, @tetienne, @nyroDev, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Should we update legacy config entries? May be add a test? |
Based on feedback on my previous PR, I removed the migration because it could be solved by providing a default value when the key is missing. There were more keys that were renamed, but they kept the original name in the end, to make it easier for people to rollback to a previous version. I can add a migration and simplify the getters, or add test :). |
Simplifying is okay. A test with a legacy entry too. You can add a remark to remember when it can be removed. |
@jbouwh would current proposal be ok for a merge? I will put this full change (as suggested) on the backlog, but a short-term fix in the next beta would be great. Due to time challenges, I haven't been able to spend much time on this unfortunately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Thnx @iMicknl 👍
Proposed change
For the local API, we first had a ConfigFlow migration, however due to feedback we removed the migration and added the value as optional and retrieve it via
.get()
. We forgot to do the same in the AuthFlow..Fixes #106204
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: