New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coordinator to Swiss public transport #106278
Conversation
Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
6ebde5f
to
bcb493e
Compare
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
bcb493e
to
5b22f00
Compare
55c8c9f
to
bdfd7db
Compare
bdfd7db
to
343f288
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @miaucl 👍
../Frenck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comment in a new PR. Thanks!
Breaking change
Proposed change
The usage of the state attributes is not encouraged anymore, therefore a device and multiple sensor implementation is planned. In preparation of that, the data fetching is outsourced into a data update coordinator. The functionality of the integration does not change in this PR.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: