New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated Life360 yaml configuration #106286
Conversation
660dff0
to
0e8ba8d
Compare
1babda7
to
6ed2ebe
Compare
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Why does it keep saying the branch is out of date and needs to be updated? I've rebased twice, and both times it's not satisfied. I don't remember this happening before. |
That button lights up automatically when your branch is not the same as dev. But as long as dev does not have changes for this integration or linting changes (new ruff/mypy/whatever) you can just ignore it. |
Per review, these are no longer needed.
@pnbruckner Can you please update the description and add a breaking change section where we write that the deprecated and not usable yaml config is finally removed or something similar :) |
Is the breaking change wording I just added ok? |
@pnbruckner I would add the HA version since it was deprecated instead of the 1.5 year. |
@edenhaus done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pnbruckner 👍
FYI, the integration broke again this morning. It's not even clear what changed and how to compensate for it. It has become too difficult to keep up. It might be time to simply remove this integration. If some sort of arrangement can be worked out with Life360 to provide a supported API, then maybe it can be brought back, but I'm not holding my breath. Should I submit another PR to remove the integration? Not even sure exactly how to do that? |
Breaking change
YAML configuration was deprecated in release 2022.7. Support for it has now been completely removed. If you still have
life360
in your YAML configuration, you should remove it completely.Proposed change
Simplify Life360 config by using cv.config_entry_only_config_schema.Completely remove all support for YAML configuration and associated deprecation warning.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: