Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Life360 yaml configuration #106286

Merged
merged 2 commits into from Jan 2, 2024
Merged

Conversation

pnbruckner
Copy link
Contributor

@pnbruckner pnbruckner commented Dec 23, 2023

Breaking change

YAML configuration was deprecated in release 2022.7. Support for it has now been completely removed. If you still have life360 in your YAML configuration, you should remove it completely.

Proposed change

Simplify Life360 config by using cv.config_entry_only_config_schema.
Completely remove all support for YAML configuration and associated deprecation warning.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

homeassistant/components/life360/__init__.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft December 26, 2023 17:53
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@pnbruckner pnbruckner marked this pull request as ready for review December 26, 2023 18:14
@pnbruckner
Copy link
Contributor Author

Why does it keep saying the branch is out of date and needs to be updated? I've rebased twice, and both times it's not satisfied. I don't remember this happening before.

@joostlek
Copy link
Member

That button lights up automatically when your branch is not the same as dev. But as long as dev does not have changes for this integration or linting changes (new ruff/mypy/whatever) you can just ignore it.

Per review, these are no longer needed.
@edenhaus edenhaus changed the title Simplify Life360 config Remove deprecated life360 yaml configuration Dec 28, 2023
@edenhaus
Copy link
Contributor

@pnbruckner Can you please update the description and add a breaking change section where we write that the deprecated and not usable yaml config is finally removed or something similar :)

@edenhaus edenhaus changed the title Remove deprecated life360 yaml configuration Remove deprecated Life360 yaml configuration Dec 28, 2023
@pnbruckner
Copy link
Contributor Author

Is the breaking change wording I just added ok?

@edenhaus
Copy link
Contributor

edenhaus commented Jan 2, 2024

@pnbruckner I would add the HA version since it was deprecated instead of the 1.5 year.
When did we add cv.removed? From this version, the yaml configuration was no longer used (It was ignored). I would add this info too as it tells the user that since that version, the yaml config was useless.
What do you think?

@pnbruckner
Copy link
Contributor Author

@edenhaus done.

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pnbruckner 👍

@edenhaus edenhaus merged commit 4bfeb87 into dev Jan 2, 2024
23 checks passed
@edenhaus edenhaus deleted the life360-simplify-config branch January 2, 2024 16:43
@pnbruckner
Copy link
Contributor Author

@joostlek @edenhaus

FYI, the integration broke again this morning. It's not even clear what changed and how to compensate for it. It has become too difficult to keep up. It might be time to simply remove this integration. If some sort of arrangement can be worked out with Life360 to provide a supported API, then maybe it can be brought back, but I'm not holding my breath.

Should I submit another PR to remove the integration? Not even sure exactly how to do that?

@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants