Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics to A. O. Smith integration #106343

Merged
merged 3 commits into from
Jan 6, 2024

Conversation

bdr99
Copy link
Contributor

@bdr99 bdr99 commented Dec 24, 2023

Proposed change

Add diagnostics support to the A. O. Smith integration.

Upgraded the client library in order to get the functionality needed for diagnostics.
bdr99/py-aosmith@1.0.1...1.0.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@joostlek
Copy link
Member

joostlek commented Jan 6, 2024

Test failure unrelated

@joostlek joostlek merged commit 4af47a4 into home-assistant:dev Jan 6, 2024
47 of 48 checks passed
jmuf pushed a commit to jmuf/homeassistant_core that referenced this pull request Jan 6, 2024
* Add diagnostics to A. O. Smith integration

* Bump py-aosmith to 1.0.4

* remove redactions from test fixture
jmuf pushed a commit to jmuf/homeassistant_core that referenced this pull request Jan 7, 2024
* Add diagnostics to A. O. Smith integration

* Bump py-aosmith to 1.0.4

* remove redactions from test fixture
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
@joostlek joostlek added this to the 2024.1.3 milestone Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants