Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid clearing the attr cache in setter when nothing has changed #106384

Merged
merged 3 commits into from Dec 25, 2023
Merged

Avoid clearing the attr cache in setter when nothing has changed #106384

merged 3 commits into from Dec 25, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 25, 2023 •
edited

Proposed change

The setter gets called frequently even though nothing has changed which makes the getter have to recreate the cache. With this change ~96% of the sets are eliminated on my production system which means we get significantly more cache hits.

before
before_setter

after
after_setter

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Avoid clear attr cache in setter when nothing has changed
3e6babf 
The setter gets called frequently even though nothing has changed
which makes the getter have to recreate the cache
@bdraco bdraco marked this pull request as ready for review December 25, 2023 18:34
@bdraco bdraco requested a review from a team as a code owner December 25, 2023 18:34
@bdraco bdraco changed the title Avoid clear attr cache in setter when nothing has changed Avoid clearing the attr cache in setter when nothing has changed Dec 25, 2023
@bdraco bdraco changed the title Avoid clearing the attr cache in setter when nothing has changed Avoid clearing the attr cache in setter when nothing has changed Dec 25, 2023
@jbouwh
Copy link
Contributor

jbouwh commented Dec 25, 2023

#106385 to fix the CI test

jbouwh
jbouwh approved these changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thnx @bdraco 👍

@bdraco
Copy link
Member Author

bdraco commented Dec 25, 2023

Thanks

@bdraco bdraco merged commit eb3fde7 into dev Dec 25, 2023
49 checks passed
@bdraco bdraco deleted the attr_cache_clear branch December 25, 2023 19:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbouwh jbouwh jbouwh approved these changes

Assignees
No one assigned
Labels
cla-signed code-quality core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bdraco @jbouwh