Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Airzone Cloud Air Quality zone binary sensors #106573

Merged

Conversation

Noltari
Copy link
Contributor

@Noltari Noltari commented Dec 28, 2023

Proposed change

Add Airzone Cloud Air Quality zone binary sensors.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please excuse the fact that I don't know a lot about this product!

I am slightly confused about 'air quality' being a binary (true/false) sensor. Is this reporting air quality or simply reporting that an air quality feature is active?

In either case I suggest the description could be adjusted to make this clearer e.g. "Air Quality Active", and a documentation PR is needed also.

@home-assistant home-assistant bot marked this pull request as draft February 10, 2024 09:44
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Add "active" to indicate status.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari
Copy link
Contributor Author

Noltari commented Feb 21, 2024

Please excuse the fact that I don't know a lot about this product!

@davet2001 oh, there's no need to excuse yourself for that! :)

I am slightly confused about 'air quality' being a binary (true/false) sensor. Is this reporting air quality or simply reporting that an air quality feature is active?

Yes, it reports the Air Quality activity (running or not).

In either case I suggest the description could be adjusted to make this clearer e.g. "Air Quality Active", and a documentation PR is needed also.

Sure! Change done in bd7aa97.
And I will create a documentation PR.

Thanks!

Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @Noltari! 👍

@cgarwood cgarwood merged commit 766596a into home-assistant:dev Feb 24, 2024
23 checks passed
@Noltari Noltari deleted the airzone-cloud-air-quality-binary-sensors branch February 24, 2024 13:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants