New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Airzone Cloud Air Quality zone binary sensors #106573
Add Airzone Cloud Air Quality zone binary sensors #106573
Conversation
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please excuse the fact that I don't know a lot about this product!
I am slightly confused about 'air quality' being a binary (true/false) sensor. Is this reporting air quality or simply reporting that an air quality feature is active?
In either case I suggest the description could be adjusted to make this clearer e.g. "Air Quality Active", and a documentation PR is needed also.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
…ality-binary-sensors
Add "active" to indicate status. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@davet2001 oh, there's no need to excuse yourself for that! :)
Yes, it reports the Air Quality activity (running or not).
Sure! Change done in bd7aa97. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @Noltari! 👍
Proposed change
Add Airzone Cloud Air Quality zone binary sensors.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: