Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Set volume_step in monoprice media_player" #106580

Merged
merged 1 commit into from Dec 28, 2023

Conversation

emontnemery
Copy link
Contributor

Reverts #105670

There was some additional issues brought up in home-assistant/architecture#1012 after this PR was merged. This functionality needs to be reverted until they way forward is clear.

@home-assistant
Copy link

Hey there @etsinko, @OnFreund, mind taking a look at this pull request as it has been labeled with an integration (monoprice) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of monoprice can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign monoprice Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@emontnemery emontnemery added this to the 2024.1 milestone Dec 28, 2023
@emontnemery emontnemery merged commit 20d1560 into dev Dec 28, 2023
22 of 23 checks passed
@emontnemery emontnemery deleted the revert-105670-monoprice_volume_step branch December 28, 2023 18:54
bramkragten pushed a commit that referenced this pull request Dec 28, 2023
Revert "Set volume_step in monoprice media_player (#105670)"

This reverts commit cffb51e.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants