Add Sanix integration #106785
Add Sanix integration #106785
Conversation
home-assistant
bot
added
cla-needed
has-tests
new-integration
integration: sanix
labels
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
tomaszsluszniak
force-pushed
the
sanix_integration
branch
from
5e440b8
to
dcdff76
Compare
|
You don't really benefit from rebasing your branch at this point btw :) |
|
I know, just waiting for my PyPi package to be published :P |
|
Ah nice work! |
|
Yep, you messed up a bit. I can't directly push to the branch (or I should be able to but I never got it working). I think it's best to start over the PR |
tomaszsluszniak
force-pushed
the
sanix_integration
branch
from
f5755a1
to
82cfb6d
Compare
| native_value_fn: Callable[[Measurement], int | datetime | date | str | None] = ( | ||
| lambda data: None | ||
| ) |
There was a problem hiding this comment.
| native_value_fn: Callable[[Measurement], int | datetime | date | str | None] = ( | |
| lambda data: None | |
| ) | |
| native_value_fn: Callable[[Measurement], int | datetime | date | str] |
This change was unneeded
There was a problem hiding this comment.
I added this due to the failing test_load_unload_entry test. Or maybe there is a problem with the test itself. I'm not sure about how it works... or should (I did that based on your test).
| ) | ||
|
|
||
| @property | ||
| def native_value(self) -> int | datetime | date | str | None: |
There was a problem hiding this comment.
| def native_value(self) -> int | datetime | date | str | None: | |
| def native_value(self) -> int | datetime | date | str: |
tests/components/sanix/test_init.py
Outdated
|
|
||
| assert entry.state == ConfigEntryState.LOADED | ||
|
|
||
| await hass.config_entries.async_remove(entry.entry_id) |
There was a problem hiding this comment.
| await hass.config_entries.async_remove(entry.entry_id) | |
| await hass.config_entries.async_unload(entry.entry_id) |
|
Can you maybe push it with those changes? Maybe I can take a look on why it fails |
sure, pushed. |
@joostlek did you find some time to look at it? |
|
Oh lol, never followed up on it |
| from .coordinator import SanixCoordinator | ||
|
|
||
|
|
||
| @dataclass(frozen=True, kw_only=True) |
There was a problem hiding this comment.
The reason tests failed was because kw_only=True was missing
There was a problem hiding this comment.
That was quick ;D thanks a lot
|
I now also changed serial_no to serial_number as I might create a shared |
|
I had this notification in my saved notifications and I can remember that I thought at some point like: man, that PR is almost done, when will he follow up on it? (because the state was draft) |
|
It seems that I forgot to change the state :/ |
|
By the way, what is your discord username? (if you have one) |
|
|
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: