Prevent toggle from calling stop on covers which do not support it

[vexofp]

Proposed change

Previously, it was possible for the core CoverEntity implementation of toggle() to call stop_cover(), even when the entity's supported_features did not include CoverEntityFeature.STOP. (#106791) The default implementation of stop_cover() was a no-op, so this ended up just doing nothing.

This could only happen in the case where the entity without STOP support still reported an opening/closing transitional state, which is presumably unusual? The cover tests and the existing MockCover assumed that the two went hand-in-hand, at least. Nonetheless, a search turned up the following integrations where this case appears possible

• opengarage
• smartthings
• gogogate2
• modbus
• linear_garage_door
• brunt
• tailwind

I updated the core CoverEntity to map toggle() while opening/closing to close_cover()/open_cover(), respectively, when stop_cover() is not available. This seems like the most reasonable interpretation of that intent under the circumstances?

I also added support to MockCover and the tests for this case.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Cover toggle incorrectly calls stop when not supported #106791
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (cover) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of cover can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign cover Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[bdraco]

LGTM. Would like another set of 👀 before merging

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[MartinHjelmare]

If we want to use in for the check instead of the bitwise operator & we need to implement supported_features_compat, and use that instead.

Example:

core/homeassistant/components/climate/__init__.py

Line 665 in c96f986

def supported_features_compat(self) -> ClimateEntityFeature:

[emontnemery]

Let's then just use & here for now. Changing CoverEntityFeature to support in can be done in a follow-up.