Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor drop sensor tests #106965

Merged
merged 3 commits into from Jan 4, 2024
Merged

Refactor drop sensor tests #106965

merged 3 commits into from Jan 4, 2024

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Jan 3, 2024

Proposed change

Removes setting states in the CI tests, and the float, round and int converstions when asserting the state.

Somehow the tests seem influence each other, which is not good. The individual tests pass, but when executed together the states seem to be persistant in some cases. For this reason I expect the CI tests to fail.

Needs: ChandlerSystems/dropmqttapi#1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 3, 2024

Hey there @ChandlerSystems, @pfrazer, mind taking a look at this pull request as it has been labeled with an integration (drop_connect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of drop_connect can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign drop_connect Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@pfrazer pfrazer mentioned this pull request Jan 3, 2024
20 tasks
@jbouwh jbouwh marked this pull request as ready for review January 3, 2024 20:53
Copy link
Contributor

@pfrazer pfrazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass with API change; LGTM. Thanks.

@jbouwh jbouwh merged commit 5508bb3 into dev Jan 4, 2024
23 checks passed
@jbouwh jbouwh deleted the jbouwh-drop-improve-sensor-tests branch January 4, 2024 09:43
@jbouwh jbouwh mentioned this pull request Jan 4, 2024
20 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants