Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ESPHome service removal when the device name contains a dash #107015

Merged
merged 3 commits into from Jan 4, 2024
Merged

Fix ESPHome service removal when the device name contains a dash #107015

merged 3 commits into from Jan 4, 2024

Commits on Jan 3, 2024

  1. Fix ESPHome service removal when the device name contains a dash 

    If the device name contains a dash the service name is mutated to
replace the dash with an underscore, but the remove function did
not do the same mutation so it would fail to remove the service
    @bdraco
    bdraco committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    e0d43d2 View commit details
    Browse the repository at this point in the history

  2. add more coverage

    @bdraco
    bdraco committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    c948442 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. more cover

    @bdraco
    bdraco committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    f6c919a View commit details
    Browse the repository at this point in the history