Include deprecated constants in wildcard imports

[emontnemery]

Proposed change

Include deprecated constants in wildcard imports to avoid breaking custom components

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[edenhaus]

@emontnemery Should we also free the globals() of the other two calls (check_if_deprecated_constant and all_with_deprecated_constants)?

[emontnemery]

@emontnemery Should we also free the globals() of the other two calls (check_if_deprecated_constant and all_with_deprecated_constants)?

check_if_deprecated_constant: I don't see a reason to freeze it here
all_with_deprecated_constants: I think all_with_deprecated_constants should iterate over a copy in case the globals dict is mutated by another thread while we loop over it, I'll add that 👍

[edenhaus]

Thanks @emontnemery 👍

[edenhaus]

CI / Run tests Python 3.12 (3) (pull_request) failed unrelated

FAILED tests/components/fritz/test_sensor.py::test_sensor_setup - AssertionError: assert 'unavailable' == '1.2.3.4'

[edenhaus]

FAILED tests/components/wemo/test_sensor.py::TestInsightTodayEnergy::test_async_update_locked_multiple_callbacks - AssertionError

is unrelated too

[hmmbob]

This now fills logs with a warning about every constant imported through wildcard by a custom_component, even though the constant isn't even accessed. Will create an issue.

[frenck]

This now fills logs with a warning about every constant imported through wildcard by a custom_component, even though the constant isn't even accessed. Will create an issue.

Technically, that is correct. The wildcard import means they access them all.