Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add select platform to Vogel's MotionMount integration #107132

Merged

Conversation

RJPoelstra
Copy link
Contributor

@RJPoelstra RJPoelstra commented Jan 4, 2024

Proposed change

This PR adds an additional entity to the Vogel's MotionMount integration.
It allows selection from a list of (user configured) presets. The first preset (0) is a system preset that's always available.
Preset changes are not pushed, so the list is configured to fetch any new preset configuration when the user chooses a preset from the list.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add one platform at a time

@RJPoelstra
Copy link
Contributor Author

Hi @joostlek, it isn't even ready for review yet :) I'll adapt it to include only a single platform. Can you comment on the error status sensor already (as mentioned in the additional info section)? Then I can work on that one as well, if needed.

@joostlek
Copy link
Member

joostlek commented Jan 4, 2024

Sure! Just wanted to give an heads up :)

@RJPoelstra RJPoelstra marked this pull request as ready for review January 4, 2024 14:37
@RJPoelstra RJPoelstra changed the title Add more entities to Vogel's MotionMount integration Add new platform to Vogel's MotionMount integration Jan 4, 2024
homeassistant/components/motionmount/select.py Outdated Show resolved Hide resolved
homeassistant/components/motionmount/select.py Outdated Show resolved Hide resolved
homeassistant/components/motionmount/select.py Outdated Show resolved Hide resolved
@RJPoelstra RJPoelstra marked this pull request as draft January 5, 2024 12:17
@bdraco bdraco changed the title Add new platform to Vogel's MotionMount integration Add select platform to Vogel's MotionMount integration Jan 6, 2024
@bdraco bdraco merged commit c833f27 into home-assistant:dev Jan 7, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2024
@RJPoelstra RJPoelstra deleted the add-entities-to-motionmount branch January 22, 2024 07:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants