Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove file/line annotations after config has been validated #107139

Merged
merged 5 commits into from Jan 14, 2024

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Jan 4, 2024

Proposed change

Remove file/line annotations after config has been validated

Rationale:

File and line annotations are attached in string items in loaded configuration in a str subclass. This is causing issues with several libraries which don't expect str to be subclassed.

Needs #107807

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck marked this pull request as draft January 8, 2024 08:27
@frenck
Copy link
Member

frenck commented Jan 8, 2024

Converted to draft, as the CI is failing.

@emontnemery emontnemery marked this pull request as ready for review January 11, 2024 16:37
@emontnemery emontnemery marked this pull request as draft January 11, 2024 17:06
@emontnemery emontnemery reopened this Jan 11, 2024
@emontnemery emontnemery marked this pull request as ready for review January 12, 2024 14:14
@frenck frenck merged commit 5e79cd8 into dev Jan 14, 2024
97 of 99 checks passed
@frenck frenck deleted the config_drop_annotations branch January 14, 2024 10:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants