New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for JSON fragments #107213
Merged
Merged
Add support for JSON fragments #107213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
bdraco
changed the title
Add support for JSON fragments to the helper
Add support for JSON fragments
Jan 5, 2024
bdraco
commented
Jan 5, 2024
the naming was intented to make it clear you get back a mutable object and should be careful but its already prefixed with _ to indicate its protected
balloob
approved these changes
Jan 8, 2024
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
#102870 (comment)
Currently we have multiple copies a state in memory in different formats depending on which api asks for them. This will allow for better reuse of objects between formats and reduce the amount of serializations.
A common case for this is serializing state_changed
Event
objects sincenew_state
andold_state
can now use the previously serialized fragment instead of recreating it again. Additionally restore state can now reuse the fragment instead of serializing again each time it writes to disk.We also avoid constructing a lot of
ReadOnlyDict
for the cases were the data is never exposed outside of core and only used to create json.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: