New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for tedee integration #107238
Merged
joostlek
merged 6 commits into
home-assistant:dev
from
zweckj:feature/tedee-improvements
Jan 10, 2024
Merged
Improvements for tedee integration #107238
joostlek
merged 6 commits into
home-assistant:dev
from
zweckj:feature/tedee-improvements
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
code-quality
dependency
has-tests
integration: tedee
small-pr
PRs with less than 30 lines.
by-code-owner
Quality Scale: No score
labels
Jan 5, 2024
Hey there @patrickhilker, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
joostlek
approved these changes
Jan 10, 2024
catsmanac
pushed a commit
to catsmanac/ha-core-dev
that referenced
this pull request
Jan 10, 2024
* improvements * wait another second before creating the entry * move delay to lib * move library bump to separate PR * move available back to lock from entity
enioo22
pushed a commit
to enioo22/bzutech-core
that referenced
this pull request
Jan 10, 2024
* improvements * wait another second before creating the entry * move delay to lib * move library bump to separate PR * move available back to lock from entity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugfix
by-code-owner
cla-signed
code-quality
dependency
has-tests
integration: tedee
Quality Scale: No score
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Added improvements for tedee integration:
lock
from theentity
, because if a lock can still reportis_connected
that means the bridge still can be read and all the other properties can still be updated, so no need to make themunavailable
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: