Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Spotify DJ #107268

Merged
merged 3 commits into from Jan 6, 2024
Merged

Conversation

BTMorton
Copy link
Contributor

@BTMorton BTMorton commented Jan 5, 2024

Proposed change

Add support for the new Spotify DJ feature by mocking the playlist response. The Spotify Web API currently doesn't support the DJ feature and returns a 404 error when trying to lookup the playlist details. If the context contains the URI for the DJ playlist, instead of performing a playlist lookup, a mock playlist object will be used to provide the minimal set of required playlist data.

I've also added some extra error handling around the playlist lookup to prevent a failing playlist request breaking the current playback state update. This error handling by itself could fix the issue, but I wanted to also have the media_playlist property be populated if the DJ URI is detected.

I've used this URI as the DJ playlist URI as it seems to be the same in my testing and from other users requesting support on the Spotify Community website:

spotify:playlist:37i9dQZF1EYkqdzj48dyYq

Spotify Community support requests:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 5, 2024

Hey there @frenck, @joostlek, mind taking a look at this pull request as it has been labeled with an integration (spotify) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of spotify can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign spotify Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Add error handling for playlist lookup to ensure it doesn't break current playback state loading
Add exception type to playlist lookup error handling
@home-assistant home-assistant bot marked this pull request as draft January 5, 2024 21:09
@home-assistant
Copy link

home-assistant bot commented Jan 5, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@BTMorton BTMorton marked this pull request as ready for review January 5, 2024 21:32
@home-assistant home-assistant bot requested a review from joostlek January 5, 2024 21:32
@joostlek joostlek merged commit 427f7a7 into home-assistant:dev Jan 6, 2024
23 checks passed
@joostlek joostlek added this to the 2024.1.3 milestone Jan 6, 2024
jmuf pushed a commit to jmuf/homeassistant_core that referenced this pull request Jan 6, 2024
* Add support for the Spotify DJ playlist by mocking the playlist response
Add error handling for playlist lookup to ensure it doesn't break current playback state loading

* Run linters
Add exception type to playlist lookup error handling

* Fix typo in comment

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>

---------

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@BTMorton BTMorton deleted the spotify-dj-support branch January 6, 2024 21:46
jmuf pushed a commit to jmuf/homeassistant_core that referenced this pull request Jan 7, 2024
* Add support for the Spotify DJ playlist by mocking the playlist response
Add error handling for playlist lookup to ensure it doesn't break current playback state loading

* Run linters
Add exception type to playlist lookup error handling

* Fix typo in comment

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>

---------

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spotify DJ AI not working with the Spotify integration on HA
3 participants