Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show default profiles in homematic cloud climate entity #107348

Merged
merged 7 commits into from
Apr 19, 2024
Merged

Show default profiles in homematic cloud climate entity #107348

merged 7 commits into from
Apr 19, 2024

Conversation

hahn-th
Copy link
Contributor

@hahn-th hahn-th commented Jan 6, 2024 •
edited

Proposed change

Showing heating profiles in climate entity, if they have no custom name in the Homematicip App. If they have a custom name, they are already displayed.
Profiles are shown with following names:
PROFILE_1 = Default
PROFILE_2 = Alternative 1
PROFILE_3 = Alternative 2

This fixes issue #101455

After i made some mistakes with rebasing in PR #101985 i decided to start from scratch and open a new pull request.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@hahn-th
Copy link
Contributor Author

hahn-th commented Jan 6, 2024

@chbndrhnns
Next try after i make a mistake with the last rebase. Maybe you can give your review. Nothing has changed.

chbndrhnns
chbndrhnns reviewed Jan 6, 2024
View reviewed changes
tests/components/homematicip_cloud/test_climate.py
]


async def test_hmip_heating_profile_naming(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is unclear to me for several reasons:

  1. I expect an arrange/act/assert structure for each test. This test asserts in between, it asserts on many unrelated things and it ends with an action that is never asserted upon.

  2. I would also expect a test which checks that a default profile name also shows up nicely

@chbndrhnns
Copy link

@davet2001 LGTM now

@hahn-th
Copy link
Contributor Author

hahn-th commented Jan 8, 2024

@chbndrhnns
Thanks for the review!

@emontnemery
Copy link
Contributor

@hahn-th Please fix the merge conflicts, then hit the "Ready for review"-button

@emontnemery emontnemery marked this pull request as draft April 17, 2024 14:27
@davet2001 davet2001 marked this pull request as ready for review April 17, 2024 23:11
@davet2001 davet2001 marked this pull request as draft April 17, 2024 23:12
@hahn-th hahn-th marked this pull request as ready for review April 18, 2024 09:06
@emontnemery
Copy link
Contributor

@hahn-th please answer the two unresolved review comment too 👍

@hahn-th
Copy link
Contributor Author

hahn-th commented Apr 18, 2024

@hahn-th please answer the two unresolved review comment too 👍

Done 👍

@emontnemery emontnemery marked this pull request as draft April 18, 2024 13:45
@emontnemery
Copy link
Contributor

Please remove the unrelated changes and hit the "Ready for review button" when done.

@hahn-th hahn-th marked this pull request as ready for review April 18, 2024 20:12
emontnemery
emontnemery approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hahn-th 👍

CODEOWNERS
Comment on lines +602 to +603
/homeassistant/components/homematicip_cloud/ @hahn-th
/tests/components/homematicip_cloud/ @hahn-th
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@emontnemery emontnemery merged commit ed4f002 into home-assistant:dev Apr 19, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chbndrhnns chbndrhnns chbndrhnns left review comments

@emontnemery emontnemery emontnemery approved these changes

Assignees
No one assigned
Labels
cla-signed has-tests integration: homematicip_cloud new-feature Quality Scale: silver small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default heating profile cannot be selected
3 participants
@hahn-th @chbndrhnns @emontnemery