Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix evohome high_precision temps not retreived consistently #107366

Merged
merged 7 commits into from Jan 7, 2024
Merged

Fix evohome high_precision temps not retreived consistently #107366

merged 7 commits into from Jan 7, 2024

Conversation

zxdavb
Copy link
Contributor

@zxdavb zxdavb commented Jan 6, 2024 •
edited

Proposed change

This is a fix for a bug introduced in 2024.1.0. Please could we merge into 2024.1.x?

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@zxdavb
Copy link
Contributor Author

zxdavb commented Jan 6, 2024 •
edited

The cause of this bug is that the current_temperature property of the climate entities are invoked before the broker (which is not an DataUpdateCoordinator) has completed its async_update() (which calls two RESTful APIs).

@zxdavb zxdavb changed the title WIP: Evohome bugfix #107198: high_precision temps not retreived Evohome bugfix #107198: high_precision temps not retreived Jan 6, 2024
@zxdavb zxdavb changed the title Evohome bugfix #107198: high_precision temps not retreived Evohome fix #107198: high_precision temps not retreived Jan 6, 2024
@zxdavb zxdavb changed the title Evohome fix #107198: high_precision temps not retreived evohome: fix #107198: high_precision temps not retreived Jan 6, 2024
@MartinHjelmare MartinHjelmare changed the title evohome: fix #107198: high_precision temps not retreived Fix evohome high_precision temps not retreived Jan 7, 2024
@zxdavb zxdavb changed the title Fix evohome high_precision temps not retreived Fix evohome high_precision temps not retreived consistently Jan 7, 2024
MartinHjelmare
MartinHjelmare approved these changes Jan 7, 2024
View reviewed changes
homeassistant/components/evohome/__init__.py
@@ -654,6 +658,7 @@ def current_temperature(self) -> float | None:
assert isinstance(self._evo_device, evo.HotWater | evo.Zone) # mypy check

if self._evo_broker.temps.get(self._evo_id) is not None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: If we store the value in a walrus variable we don't need to look it up twice.

@MartinHjelmare MartinHjelmare added this to the 2024.1.3 milestone Jan 7, 2024
@MartinHjelmare MartinHjelmare merged commit 2a8444b into home-assistant:dev Jan 7, 2024
18 checks passed
@zxdavb zxdavb deleted the evo_bugfix_v1_temps branch January 7, 2024 19:15
mkmer pushed a commit to mkmer/HomeAssistant_Core that referenced this pull request Jan 8, 2024
@zxdavb @mkmer
Fix evohome high_precision temps not retreived consistently (home-ass…
a13b17c 
…istant#107366)

* initial commit

* doctweak

* remove hint

* doctweak
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed integration: evohome Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2024.1.3
Development

Successfully merging this pull request may close these issues.

evohome: high precision temperatures not retrieved consistently
3 participants
@zxdavb @MartinHjelmare @frenck