Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix language flavors in holiday #107392

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Fix language flavors in holiday #107392

merged 2 commits into from
Jan 8, 2024

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented Jan 6, 2024

Proposed change

Language fix for holiday integration.
Library only support overall country language codes mainly so for example nb (Norsk bokmål) isn't resolving to no which is needed for the correct language.
This fix sets the default language for the country if the language is not found.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 6, 2024

Hey there @jrieger, mind taking a look at this pull request as it has been labeled with an integration (holiday) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of holiday can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign holiday Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@gjohansson-ST
Copy link
Member Author

@jrieger what do you think?

@jrieger
Copy link
Contributor

jrieger commented Jan 6, 2024

Looks good for me. Could you add a test?

@gjohansson-ST
Copy link
Member Author

I added the test but what I mean do we really want to have the default language for the country as the fallback language or should that always be English or what do you think?

Let's say I want to have Portugal calendar because I have a holiday home in that country. Would I (as Swede having my HA configured with Swedish as example) want to have the calendar then in English or in Portuguese?
It depends I guess but we need to make a choice and if Portuguese then this PR is complete, if English then it just became much more advanced.

@jrieger
Copy link
Contributor

jrieger commented Jan 6, 2024

IMHO it's more important to provide people living in Norway their calendar in their language, than paying attention on some edge cases like holiday apartments.

@gjohansson-ST gjohansson-ST marked this pull request as ready for review January 6, 2024 17:52
@stigvi
Copy link

stigvi commented Jan 6, 2024

FYI: I have checked the pull request on my installation and it is working as expected with norwegian language.

:-)

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gjohansson-ST 👍

@edenhaus edenhaus merged commit d8c139f into dev Jan 8, 2024
23 checks passed
@edenhaus edenhaus deleted the holiday-fix-language-flavors branch January 8, 2024 08:31
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants