Refactor translations to reduce dict lookups #107425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
TLDR: the O(n) lookup (set of components) is now at the tail of the cache instead of having to transverse it in the middle of the cache. This allows the cache fetch to avoid looking up the
category
each loop.This started to matter a bit more now that we translate a lot more things.
All of our cache lookups used:
cache[language][O(component)][category]
The cache was designed as
cache[language][component][category][flatted_key]
The lookups are now
cache[language][category][O(component)]
The cache is now stored as
cache[language][category][component][flatted_key]
This provides better alignment with how the fetch function asks for the data
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: