Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle deep standby and poweroffs of enigma2 devices gracefully #107462

Merged
merged 8 commits into from Feb 17, 2024

Conversation

autinerd
Copy link
Contributor

@autinerd autinerd commented Jan 7, 2024

Proposed change

This adds the graceful handling of enigma2 devices going offline or into deep standby.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title Handle deep standby and poweroffs of enigma2 devices gracefully. Handle deep standby and poweroffs of enigma2 devices gracefully Jan 7, 2024
@autinerd autinerd marked this pull request as ready for review January 12, 2024 17:05
@dierochade
Copy link

@MartinHjelmare Could you spare some time to take a look at this? The PR has been open for review for some time (a month+) and – although I cant judge if its good – I would like to see the problem solved. THANKS.

homeassistant/components/enigma2/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/enigma2/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/enigma2/media_player.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 17, 2024 09:40
@autinerd autinerd marked this pull request as ready for review February 17, 2024 10:25
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2024.2.3 milestone Feb 17, 2024
@MartinHjelmare MartinHjelmare merged commit 926a634 into home-assistant:dev Feb 17, 2024
18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants