Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry zoneminder connection setup #107519

Merged
merged 9 commits into from
Jan 8, 2024

Conversation

nabbi
Copy link
Contributor

@nabbi nabbi commented Jan 8, 2024

Makes ZM setup be async for enabling connection retry attempts

This also requires zm-py version bump v0.5.4 as that dependency was patched in conjunction to resolve this issue

Closes #105271

Proposed change

Enable setup connection retry within the ZoneMinder component

Type of change

Yes, both are needed to resolve the issue

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Makes ZM setup be async for enabling connection retry attempts

This also requires zm-py version bump v0.5.4 as that
dependency was patched in conjunction to resolve this issue

Closes home-assistant#105271

Signed-off-by: Nic Boet <nic@boet.cc>
@home-assistant
Copy link

home-assistant bot commented Jan 8, 2024

Hey there @rohankapoorcom, mind taking a look at this pull request as it has been labeled with an integration (zoneminder) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zoneminder can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zoneminder Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@nabbi nabbi marked this pull request as ready for review January 8, 2024 07:11
@MartinHjelmare MartinHjelmare changed the title zoneminder setup retry connection Retry zoneminder connection setup Jan 8, 2024
homeassistant/components/zoneminder/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/zoneminder/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/zoneminder/camera.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

home-assistant bot commented Jan 8, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 8, 2024 08:20
@nabbi nabbi marked this pull request as ready for review January 8, 2024 14:46
Signed-off-by: Nic Boet <nic@boet.cc>
@MartinHjelmare MartinHjelmare marked this pull request as draft January 8, 2024 15:39
@nabbi nabbi marked this pull request as ready for review January 8, 2024 16:10
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2024.1.3 milestone Jan 8, 2024
@MartinHjelmare MartinHjelmare merged commit e349608 into home-assistant:dev Jan 8, 2024
53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zoneminder integration doesn't retry if server not available upon startup
4 participants