Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated resource issue in System Monitor #107671

Merged
merged 2 commits into from Jan 12, 2024

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented Jan 9, 2024

Proposed change

Given that arguments can be typed in many ways it results in duplicated unique id's.
Slugify the loaded resources in the comparison to avoid this.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@jbouwh
Copy link
Contributor

jbouwh commented Jan 10, 2024

Is this not a breaking change, as it changes the ID's?

@gjohansson-ST
Copy link
Member Author

Is this not a breaking change, as it changes the ID's?

It's not changing the id's. It's just for comparisons to know which entities to make or not.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thnx @gjohansson-ST 👍

@MartinHjelmare MartinHjelmare merged commit e715d6a into dev Jan 12, 2024
23 checks passed
@MartinHjelmare MartinHjelmare deleted the systemmonitor-fix-issue-with-duplicated-resource branch January 12, 2024 07:44
frenck pushed a commit that referenced this pull request Jan 12, 2024
* Fix duplicated resource issue

* Only slug the argument
@frenck frenck mentioned this pull request Jan 12, 2024
@jymorel
Copy link

jymorel commented Jan 13, 2024

Hi,
I got these errors when updating from 2024.1.2 to 2024.1.3:
Platform systemmonitor does not generate unique IDs. ID disk_free already exists - ignoring sensor.disk_free
Platform systemmonitor does not generate unique IDs. ID disk_use_percent already exists - ignoring sensor.disk_use_percent

No more yaml with these sensors ...

@jbouwh
Copy link
Contributor

jbouwh commented Jan 13, 2024

Hi, I got these errors when updating from 2024.1.2 to 2024.1.3: Platform systemmonitor does not generate unique IDs. ID disk_free already exists - ignoring sensor.disk_free Platform systemmonitor does not generate unique IDs. ID disk_use_percent already exists - ignoring sensor.disk_use_percent

No more yaml with these sensors ...

It can be the old entities need to be removed.

@jymorel
Copy link

jymorel commented Jan 13, 2024

I don't find duplicate entities ...
sensor disk_

@jbouwh
Copy link
Contributor

jbouwh commented Jan 13, 2024

Please also look at disabled entities

@gjohansson-ST
Copy link
Member Author

See #107903

@home-assistant home-assistant locked as off-topic and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Systemmonitor does not generate unique IDs
5 participants