Dynamically map state class, device class and UoM in ZHA smart energy metering sensor #107685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @dmulcahey, @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
dmulcahey
reviewed
Jan 9, 2024
elupus
reviewed
Jan 11, 2024
MartinHjelmare
requested changes
Jan 11, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
The changed test needs to be reviewed by a code owner. The rest looks good. |
dmulcahey
reviewed
Jan 12, 2024
elupus
reviewed
Jan 12, 2024
dmulcahey
approved these changes
Jan 14, 2024
|
@MartinHjelmare i think your review is stale? Still okey with this change? |
| scale=1000, | ||
| ), | ||
| 0x0B: SmartEnergyMeteringEntityDescription( | ||
| native_unit_of_measurement="unitless", device_class=None, state_class=None |
There was a problem hiding this comment.
Side note: unitless is not a valid unit.
There was a problem hiding this comment.
Yes, but we shouldn't change it now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Currently, the status class and the device class are statically assigned for the ZHA sensors 'SmartEnergyMetering' and 'SmartEnergySummation', which leads to inadmissible use, e.g. the device class 'Energy' is assigned for a sensor measuring liters.
This PR creates a additional mapping for state class and device class besides the unit of measurement.
Noticed while doing #107639
In addition, these attributes are set in the
__init__to prevent them from being looked up again and again.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: