Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce discovery flow matching overhead #107709

Merged
merged 3 commits into from Jan 10, 2024
Merged

Reduce discovery flow matching overhead #107709

merged 3 commits into from Jan 10, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 10, 2024

Proposed change

This reduces the overhead to handle all the rediscoveries that happen at startup which is especially heavy when the user has a lot of Apple devices since they generate a lot of zeroconf updates when the network has IPv6 right after the started event.

On my production network I see ~250-300 calls to this function at started because of all the zeroconf updates.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

This reduces the overhead to handle all the rediscoveries that happen at startup
which is especially heavy when the user has a lot of Apple devices since they
generate a lot of zeroconf updates when the network has IPv6 right after the
started event
@bdraco bdraco requested a review from a team as a code owner January 10, 2024 08:21
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thnx @bdraco 👍

@bdraco
Copy link
Member Author

bdraco commented Jan 10, 2024

Thanks

@bdraco bdraco merged commit 7d18ad6 into dev Jan 10, 2024
53 checks passed
@bdraco bdraco deleted the event_loop_blocked_started branch January 10, 2024 17:14
enioo22 pushed a commit to enioo22/bzutech-core that referenced this pull request Jan 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants