Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Nuki integration to expose ringer through Nuki Opener #107745

Merged
merged 4 commits into from Jan 12, 2024

Conversation

steffenrapp
Copy link
Contributor

@steffenrapp steffenrapp commented Jan 10, 2024

Breaking change

Proposed change

As #99878 became stale I'm trying to pick this feature up.

Expose the ring_action_state from the Nuki Opener as it is always sent by the Nuki Bridge and already availabe through pynuki. ring_action_state is created as a binary_sensor.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @pschmitt, @pvizeli, @pree, mind taking a look at this pull request as it has been labeled with an integration (nuki) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of nuki can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign nuki Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@steffenrapp steffenrapp marked this pull request as ready for review January 10, 2024 19:24
homeassistant/components/nuki/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/nuki/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/nuki/binary_sensor.py Outdated Show resolved Hide resolved
Copy link
Member

@pree pree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pree pree merged commit d0e9e54 into home-assistant:dev Jan 12, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
@home-assistant home-assistant unlocked this conversation Feb 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants