Bump arris-tg2492lg to 2.2.0 #107905
Bump arris-tg2492lg to 2.2.0 #107905
Conversation
home-assistant
bot
added
cla-signed
dependency
integration: arris_tg2492lg
small-pr
There was a problem hiding this comment.
Thanks @vanbalken, looks good. Just one question.
Also, do you have this hardware and have you tested on it?
| def get_device_name(self, device: str) -> str | None: | ||
| async def async_get_device_name(self, device: str) -> str | None: |
There was a problem hiding this comment.
Was it necessary to make this function async? I couldn't see anything that needed this.
There was a problem hiding this comment.
Thx for reviewing!
I've looked at other async device trackers and they too have only async methods. Therefore I'm in the understanding that everything should be async. If we can mix async and sync methods this method can indeed by a regular sync method.
For example:
There was a problem hiding this comment.
A coroutine (as in this PR) is preferred over a sync method because the latter is allowed to block and thus has to be handed to an executor.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I've have this hardware and tested this on it. |
frenck
added
the
smash
Breaking change
This update the Arris TG2492LG library to the lastest version. Biggest change is that the library now uses AIOHTTP.
Changelog: vanbalken/arris-tg2492lg@1.2.1...2.2.0
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: