New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TICMeter Energy Metering sensors #107956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @dmulcahey, @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@xmow49 Just to confirm, since the PR title isn't entirely clear, you made these changes, so the device is polled at an interval? Like, the entities were already created before, but only updated on a HA restart? |
Before the changes, "Tier X summation delivered" entities did not show up in HA. Now I can see all the entities in my device in ZHA. Thanks |
Ah, not sure if polling is required for your device though. At least the summation delivered sensor should have been showing without the changes. But did that not update? EDIT: Nvm, the tierX sensors might not be reportable in the first place(?) |
I don't know, before the change I had only the "Summation delivered" entity in the dashboard. |
Breaking change
Proposed change
Add Energy Metering sensors for TICMeter device.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: