-
-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helper function to update and reload config entry to config flow #108034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpbede
force-pushed
the
config-flow-update-helper
branch
from
January 14, 2024 16:35
e2b7485
to
1b3f16b
Compare
bdraco
previously requested changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing, please check. Thanks
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
jpbede
force-pushed
the
config-flow-update-helper
branch
from
January 22, 2024 06:50
01aaa33
to
e57eddd
Compare
bdraco
reviewed
Jan 22, 2024
bdraco
approved these changes
Jan 22, 2024
Thanks |
20 tasks
bdraco
added a commit
that referenced
this pull request
Jan 22, 2024
Use new config entry update/abort helper in august uses the new helper from #108034
20 tasks
bdraco
added a commit
that referenced
this pull request
Jan 22, 2024
Use new config entry update/abort helper in powerwall uses the new helper from #108034
20 tasks
bdraco
added a commit
that referenced
this pull request
Jan 22, 2024
Use new config entry update/abort helper in yalexs_ble uses the new helper from #108034
20 tasks
bdraco
added a commit
that referenced
this pull request
Jan 22, 2024
Use new config entry update/abort helper in bthome uses the new helper from #108034
jpbede
pushed a commit
that referenced
this pull request
Jan 22, 2024
Use new config entry update/abort helper in isy994 uses the new helper from #108034
joostlek
pushed a commit
that referenced
this pull request
Jan 22, 2024
Use new config entry update/abort helper in enphase_envoy uses the new helper from #108034
jpbede
pushed a commit
that referenced
this pull request
Jan 22, 2024
Use new config entry update/abort helper in shelly uses the new helper from #108034
jpbede
pushed a commit
that referenced
this pull request
Jan 22, 2024
Use new config entry update/abort helper in samsungtv uses the new helper from #108034
jpbede
pushed a commit
that referenced
this pull request
Jan 22, 2024
Use new config entry update/abort helper in onvif uses the new helper from #108034
bdraco
added a commit
that referenced
this pull request
Jan 22, 2024
Use new config entry update/abort helper in apple_tv uses the new helper from #108034
20 tasks
bdraco
added a commit
that referenced
this pull request
Jan 22, 2024
Use new config entry update/abort helper in enphase_envoy uses the new helper from #108034
20 tasks
bdraco
added a commit
that referenced
this pull request
Jan 22, 2024
Use new config entry update/abort helper in bond uses the new helper from #108034
20 tasks
bdraco
added a commit
that referenced
this pull request
Jan 22, 2024
Use new config entry update/abort helper in sense uses the new helper from #108034
20 tasks
jpbede
pushed a commit
that referenced
this pull request
Jan 23, 2024
Use new config entry update/abort helper in bond uses the new helper from #108034
20 tasks
catsmanac
pushed a commit
to catsmanac/ha-core-dev
that referenced
this pull request
Jan 23, 2024
…ome-assistant#108034) * Add helper function to update and reload config entry to config flow * Use async_create_task * Remove await * Reload only when update & add task name * Rename function
catsmanac
pushed a commit
to catsmanac/ha-core-dev
that referenced
this pull request
Jan 23, 2024
…8673) Use new config entry update/abort helper in august uses the new helper from home-assistant#108034
catsmanac
pushed a commit
to catsmanac/ha-core-dev
that referenced
this pull request
Jan 23, 2024
…#108674) Use new config entry update/abort helper in powerwall uses the new helper from home-assistant#108034
catsmanac
pushed a commit
to catsmanac/ha-core-dev
that referenced
this pull request
Jan 23, 2024
…8676) Use new config entry update/abort helper in bthome uses the new helper from home-assistant#108034
catsmanac
pushed a commit
to catsmanac/ha-core-dev
that referenced
this pull request
Jan 23, 2024
…t#108677) Use new config entry update/abort helper in xiaomi_ble uses the new helper from home-assistant#108034
catsmanac
pushed a commit
to catsmanac/ha-core-dev
that referenced
this pull request
Jan 23, 2024
…t#108675) Use new config entry update/abort helper in yalexs_ble uses the new helper from home-assistant#108034
catsmanac
pushed a commit
to catsmanac/ha-core-dev
that referenced
this pull request
Jan 23, 2024
…8678) Use new config entry update/abort helper in isy994 uses the new helper from home-assistant#108034
catsmanac
pushed a commit
to catsmanac/ha-core-dev
that referenced
this pull request
Jan 23, 2024
…tant#108679) Use new config entry update/abort helper in enphase_envoy uses the new helper from home-assistant#108034
catsmanac
pushed a commit
to catsmanac/ha-core-dev
that referenced
this pull request
Jan 23, 2024
…8684) Use new config entry update/abort helper in shelly uses the new helper from home-assistant#108034
catsmanac
pushed a commit
to catsmanac/ha-core-dev
that referenced
this pull request
Jan 23, 2024
…#108683) Use new config entry update/abort helper in samsungtv uses the new helper from home-assistant#108034
catsmanac
pushed a commit
to catsmanac/ha-core-dev
that referenced
this pull request
Jan 23, 2024
) Use new config entry update/abort helper in onvif uses the new helper from home-assistant#108034
catsmanac
pushed a commit
to catsmanac/ha-core-dev
that referenced
this pull request
Jan 23, 2024
…ome-assistant#108689) Use new config entry update/abort helper in enphase_envoy uses the new helper from home-assistant#108034
catsmanac
pushed a commit
to catsmanac/ha-core-dev
that referenced
this pull request
Jan 23, 2024
Use new config entry update/abort helper in bond uses the new helper from home-assistant#108034
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
We currently use something like the following in a lot of our config flows:
So I thought it would be nice to have an helper function for this.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: