Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache commonly called Integration manifest properties #108141

Merged
merged 3 commits into from Jan 16, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 16, 2024

Proposed change

name, disabled, and especially integration_type are called frequently.

Since they never change, make the cached_properties

Since py3.12 inline list comps its much easier to see whats taking up time inside the listcomp since previously all the profiler would show is <listcomp>

and integrations[entry.domain].integration_type in type_filter

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

name, disabled, and especially integration_type are called frequently.

Since they never change, make the cached_properties
@bdraco bdraco marked this pull request as ready for review January 16, 2024 09:05
@bdraco bdraco requested a review from a team as a code owner January 16, 2024 09:05
homeassistant/loader.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft January 16, 2024 15:51
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@bdraco bdraco marked this pull request as ready for review January 16, 2024 18:07
@home-assistant home-assistant bot requested a review from frenck January 16, 2024 18:07
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit 6173bfe into dev Jan 16, 2024
53 checks passed
@frenck frenck deleted the manifest_props branch January 16, 2024 20:05
zweckj pushed a commit to zweckj/home-assistant-core that referenced this pull request Jan 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants