New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MQTT based ecovacs vacuums #108167
Conversation
Hey there @OverloadUT, @mib1185, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@@ -77,19 +95,25 @@ async def async_step_user( | |||
type=selector.TextSelectorType.PASSWORD | |||
) | |||
), | |||
vol.Required(CONF_COUNTRY): vol.All(vol.Lower, cv.string), | |||
vol.Required(CONF_CONTINENT): vol.All(vol.Lower, cv.string), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the continent requires no migration, as no stable release included the config flow of ecovacs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @edenhaus
i've tested this PR with my old Deebot slim 2 (xmpp based) and can confirm that it still works.
- migration of yaml ✅
- creating new entry ✅
- controlling the vacuum ✅
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Test failures unrelated |
Breaking change
Proposed change
Add support for MQTT based ecovacs vacuums by adding the library
deebot_client
Login and getting all devices is handled by the new library.
If we get back a legacy device, we use the old library to communicate with it.
As Ecovacs calls them legacy devices, I have renamed the existing Vacuum entity to
EcovacsLegacyVacuum
Removed
continent
from the config flow as it will be retrieved from the country.Enabled strict typing
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: