Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calendar platform to La Marzocco #108237

Merged
merged 10 commits into from Feb 21, 2024

Conversation

zweckj
Copy link
Contributor

@zweckj zweckj commented Jan 17, 2024

Breaking change

Proposed change

Add calendar platform to La Marzocco

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

homeassistant/components/lamarzocco/calendar.py Outdated Show resolved Hide resolved
homeassistant/components/lamarzocco/calendar.py Outdated Show resolved Hide resolved
homeassistant/components/lamarzocco/calendar.py Outdated Show resolved Hide resolved
homeassistant/components/lamarzocco/calendar.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 18, 2024 00:29
@zweckj zweckj marked this pull request as ready for review February 18, 2024 07:15
@home-assistant home-assistant bot marked this pull request as draft February 19, 2024 17:38
@zweckj zweckj marked this pull request as ready for review February 19, 2024 20:40
Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think the snapshots may just need to be updated against head given some other home assistant changes to add labels

@zweckj
Copy link
Contributor Author

zweckj commented Feb 20, 2024

Looks good. I think the snapshots may just need to be updated against head given some other home assistant changes to add labels

fixed!

@allenporter allenporter merged commit db77e73 into home-assistant:dev Feb 21, 2024
23 checks passed
@zweckj zweckj deleted the feature/lamarzocco-calendar-2 branch February 21, 2024 05:59
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants